Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awssqs): Support sending messages to SQS FIFO queues #261

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

thomassandslyst
Copy link
Contributor

@thomassandslyst thomassandslyst commented Jan 25, 2024

This should allow the awssqs service to send messages to FIFO SQS queues which require a MessageGroupId to be set.

@thomassandslyst thomassandslyst force-pushed the awssqs-fifo branch 6 times, most recently from c142340 to b69f571 Compare January 25, 2024 16:17
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (84b9f79) 55.19% compared to head (b16c258) 55.16%.

Files Patch % Lines
pkg/services/awssqs.go 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   55.19%   55.16%   -0.04%     
==========================================
  Files          35       35              
  Lines        3339     3350      +11     
==========================================
+ Hits         1843     1848       +5     
- Misses       1229     1233       +4     
- Partials      267      269       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomassandslyst thomassandslyst changed the title feat(awssqs): Support sending messagest to SQS FIFO queues feat(awssqs): Support sending messages to SQS FIFO queues Jan 25, 2024
@thomassandslyst thomassandslyst force-pushed the awssqs-fifo branch 3 times, most recently from ef9306f to 91007aa Compare January 30, 2024 15:35
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pasha-codefresh pasha-codefresh merged commit 85c76ec into argoproj:master Feb 1, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants